Skip to content

Conversation

@TgZ39
Copy link

@TgZ39 TgZ39 commented Dec 20, 2025

Add --disable-emojis option to cli arguments to force the use of the fallback ui elements (* and >) instead of emojis (✅ and ▶️).

@SergioGasquez
Copy link
Member

Hi! Is there any downside of using emojis?

@jessebraham
Copy link
Member

Hi! Is there any downside of using emojis?

A lot of people (like me) just find them visually noisy and/or tacky looking, and they don't really provide any real benefit, to me at least.

@TgZ39
Copy link
Author

TgZ39 commented Dec 22, 2025

Hi! Is there any downside of using emojis?

For me the problem is that my terminal (alacritty) doesn't display emojies, so i couldn't see what options I selected. Thus I wanted an option to use the fallback ASCII symbols.

@SergioGasquez
Copy link
Member

A lot of people (like me) just find them visually noisy and/or tacky looking, and they don't really provide any real benefit, to me at least.

I get it, but not sure if this deserves a flag. I think most of the people won't even know it exist, and the fact that you have to add it every single run doesn't sounds very ergonomic to me, maybe we should have a environment variable or just remove all the emojis, which Im also ok to do.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also filter the emojis that we use for tools detection, just tried this PR and I still get emojis:

     Running `target/release/esp-generate --disable-emojis`
> Select your target chip: esp32c3
> Enter project name: asdad
Selected options: --chip esp32c3 -o nightly-x86_64-unknown-linux-gnu
[2025-12-23T09:22:16Z WARN ] Current directory is already in a git repository, skipping git initialization
🛑 esp-config is not installed or is below the required version.
Do you want to run `cargo install esp-config --features=tui --locked` now? [y/N]

Checking installed versions
🆗 Rust (stable): 1.92.0
🆗 espflash: 4.3.0
🆗 probe-rs: 0.30.0
💡 esp-config (not found - use `cargo install esp-config --features=tui --locked` to install (installation is optional))

⚠️ `.config/cargo.toml` files found in parent directories - this can cause undesired behavior. See https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure

@bugadani
Copy link
Contributor

bugadani commented Dec 23, 2025

we could also invert the theme selector logic to use FALLBACK by default, and FANCY for known terminals. alacritty doesn't set TERM_PROGRAM. Or we can just remove emojis completely, although I find the blatant visual obviousness in the version check screen quite helpful

@TgZ39
Copy link
Author

TgZ39 commented Dec 23, 2025

I think removing emojis completely is a good idea. Instead of using emojis we could display warnings, errors and suggestions using colored text which is supported by more terminals and is still understandable if the terminal doesn't support colors.

@playfulFence
Copy link
Member

I'm leaning towards what @bugadani suggested with known_terminals concept. Flag for such thing will be WAY too noisy.

I'm not a big fan of emojis, but I think esp-generate sort of benefits from it, it just makes the interface visually more friendly. What Daniel suggested gives us a needed level of seamlessness, but still improving quality of life for people with emoji-unsuitable terminals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants