-
Notifications
You must be signed in to change notification settings - Fork 37
Add --disable-emojis cli argument
#280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! Is there any downside of using emojis? |
A lot of people (like me) just find them visually noisy and/or tacky looking, and they don't really provide any real benefit, to me at least. |
For me the problem is that my terminal (alacritty) doesn't display emojies, so i couldn't see what options I selected. Thus I wanted an option to use the fallback ASCII symbols. |
I get it, but not sure if this deserves a flag. I think most of the people won't even know it exist, and the fact that you have to add it every single run doesn't sounds very ergonomic to me, maybe we should have a environment variable or just remove all the emojis, which Im also ok to do. |
SergioGasquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also filter the emojis that we use for tools detection, just tried this PR and I still get emojis:
Running `target/release/esp-generate --disable-emojis`
> Select your target chip: esp32c3
> Enter project name: asdad
Selected options: --chip esp32c3 -o nightly-x86_64-unknown-linux-gnu
[2025-12-23T09:22:16Z WARN ] Current directory is already in a git repository, skipping git initialization
🛑 esp-config is not installed or is below the required version.
Do you want to run `cargo install esp-config --features=tui --locked` now? [y/N]
Checking installed versions
🆗 Rust (stable): 1.92.0
🆗 espflash: 4.3.0
🆗 probe-rs: 0.30.0
💡 esp-config (not found - use `cargo install esp-config --features=tui --locked` to install (installation is optional))
⚠️ `.config/cargo.toml` files found in parent directories - this can cause undesired behavior. See https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure
|
we could also invert the theme selector logic to use |
|
I think removing emojis completely is a good idea. Instead of using emojis we could display warnings, errors and suggestions using colored text which is supported by more terminals and is still understandable if the terminal doesn't support colors. |
|
I'm leaning towards what @bugadani suggested with I'm not a big fan of emojis, but I think |
Add▶️ ).
--disable-emojisoption to cli arguments to force the use of the fallback ui elements (* and >) instead of emojis (✅ and