Skip to content

fix(deps): allow webtest to work on python 3.13 #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbillinghamwrk
Copy link

Should fix issue #1721.

webtest is used to validate incoming webhooks in the production Webserver().

Via webtest and webob, we have a transitive dependency on cgi.
As of python 3.13 cgi has been dropped from stdlib.

The recommended stopgap is to add an explicit dependency on legacy-cgi,
long term webob should be replaced with WSGI or ASGI

Should fix issue
[errbotio#1721](errbotio#1721).

`webtest` is used to validate incomming webhooks
in the production Webserver().

Via `webtest` and `webob`,
we have a transitive dependency on `cgi`.
As of python 3.13 [`cgi` has been dropped from stdlib](https://docs.python.org/3/deprecations/pending-removal-in-3.13.html).
@lbillinghamwrk lbillinghamwrk marked this pull request as ready for review May 27, 2025 17:05
@lbillinghamwrk
Copy link
Author

I'm not 100% sure that setup.py is compatible with PEP 508 environment markers.
Pending a full test-suite workflow approval, I've tested that python -m pip install . works in both python 3.9 and 3.13.
Only the latter, as expected, has legacy-cgi present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant