Remote shell should not terminate the remote node on EOF #9912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the test so that it tests starting a remote shell to an invalid node from the switch menu
garazdawi
reviewed
Jun 5, 2025
| State#state.tty), | ||
| {keep_state, State#state{ tty = NewTTYState, groups = Gr1 }} | ||
| %% If the readhandle has terminated, then we should quit | ||
| case State#state.read =:= eof of |
There was a problem hiding this comment.
Is this code to make sure the remote node is also terminated?
Can we add tests for this?
There was a problem hiding this comment.
When state.read =:= eof is true, then we want the local node to terminate, because it's the local node's readhandle that received the EOF. The remote node should still be alive.
When state.read =:= eof is false, then the remote node has terminated. The local node should remove its "remote shell group".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9852