[Installer] API change in NSIS in DeleteRegKey use /ifnosubkeys for old behaviour

[kvakvs]

Fixes #9884
The installer for Windows leaves registry keys on uninstall
Change in API has been reported as of 3.0.6 (July 2020)

[github-actions]

CT Test Results

    3 files    142 suites   49m 29s ⏱️
1 649 tests 1 592 ✅ 57 💤 0 ❌
2 372 runs  2 295 ✅ 77 💤 0 ❌

Results for commit 7708a6b.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[dgud]

Have you built and used that installer? As far as I know we still use 3.0.5 internally i.e. for the signed releases.

[kvakvs]

Have you built and used that installer? As far as I know we still use 3.0.5 internally i.e. for the signed releases.

Hello
Yes i am using this currently to test the building of signed releases for an ESL customer, and they report the API change prevented some registry keys from being deleted on uninstall. I either have to downgrade my NSIS, or offer that fix. It is up to the OTP maintainers to decide whether they want this change or not (and document max supported NSIS version) or make a way around and support both NSIS syntaxes.

[dgud]

I just wanted to know how it happens, I guess it is time for us to upgrade.

[kvakvs]

I will report here once i build it again and the customer confirms that its looking good for their uninstall/upgrade/reinstall scenario.