Fix the features feature #10376
Merged
Fix the features feature #10376
+21
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible for erl_lint etc to react to -feature declarations in the module being compiled, not just runtime feature flags.
Even if -enable-feature was specified, the compiler only got the list of features that were enabled by default.
Contributor
CT Test Results 5 files 543 suites 1h 59m 56s ⏱️ For more details on these failures, see this check. Results for commit 112f143. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
richcarl
force-pushed
the
fix-features
branch
from
d67af12 to
112f143
Compare
bjorng
added
team:VM
bjorng
approved these changes
Nov 17, 2025
Contributor
|
Thanks! Added to our daily builds. |
Contributor
|
Thanks for your pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates the commits from #9153 that were needed to make Features work properly, without adding any new functionality.