Skip to content

tidy: packages — Critter Stack refresh (WolverineFx 6.8 → 6.17) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikshafer merged 2 commits into from
Jul 10, 2026
Merged

tidy: packages — Critter Stack refresh (WolverineFx 6.8 → 6.17) #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2c2772
tidy: packages — Critter Stack refresh (WolverineFx 6.8 → 6.17)
erikshafer Jul 10, 2026
49d2e2b
Add retro for the Critter Stack package refresh
erikshafer Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
</ItemGroup>
<!-- Wolverine -->
<ItemGroup>
<PackageVersion Include="WolverineFx" Version="6.8.0" />
<PackageVersion Include="WolverineFx.Http" Version="6.8.0" />
<PackageVersion Include="WolverineFx.Grpc" Version="6.8.0" />
<PackageVersion Include="WolverineFx.Marten" Version="6.8.0" />
<PackageVersion Include="WolverineFx.Polecat" Version="6.8.0" />
<PackageVersion Include="WolverineFx.AzureServiceBus" Version="6.8.0" />
<PackageVersion Include="WolverineFx.Kafka" Version="6.8.0" />
<PackageVersion Include="WolverineFx.SignalR" Version="6.8.0" />
<PackageVersion Include="WolverineFx.RuntimeCompilation" Version="6.8.0" />
<PackageVersion Include="WolverineFx" Version="6.17.0" />
<PackageVersion Include="WolverineFx.Http" Version="6.17.0" />
<PackageVersion Include="WolverineFx.Grpc" Version="6.17.0" />
<PackageVersion Include="WolverineFx.Marten" Version="6.17.0" />
<PackageVersion Include="WolverineFx.Polecat" Version="6.17.0" />
<PackageVersion Include="WolverineFx.AzureServiceBus" Version="6.17.0" />
<PackageVersion Include="WolverineFx.Kafka" Version="6.17.0" />
<PackageVersion Include="WolverineFx.SignalR" Version="6.17.0" />
<PackageVersion Include="WolverineFx.RuntimeCompilation" Version="6.17.0" />
</ItemGroup>
<!-- SignalR client (integration-test transport for Relay BC push assertions) -->
<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions docs/retrospectives/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ Subsequent sections are session-specific. Existing retros in this directory serv

- [`telemetry-narrative-layer-decision.md`](./telemetry-narrative-layer-decision.md) — **Narrative-layer decision session** (design-layer, no code). Resolved the single open pre-implementation question for the Telemetry chain: does a thin driver-device narrative apply, or is the narrative step skipped? Decision: **the narrative layer does not apply** — an empirical scan of W006 §6.2–§6.5 + the Ubiquitous Language found no driver-app-perceivable surface (server-side processing throughout; *driver session* defined as "a logical concept, decoupled from any physical stream"; no indicator / permission prompt / status screen named in W006 or ADR-018). Recorded in [`docs/narratives/README.md`](../narratives/README.md) via a new "When the narrative layer does not apply" section + "Skipped narratives (recorded)" table + v0.3 Document-history entry, rather than folded into the not-yet-written first implementation prompt. Mirrors W006's own EM-direct (Domain-Storytelling-skip) precedent one layer up. No prompt doc authored — a disposable planning note (`docs/planning/2026-07-10-telemetry-narrative-decision-handoff.md`) served as prompt-equivalent (W005/W006 precedent). Spec delta lands at the narratives-README convention layer (no narrative/workshop amended — that *is* the decision). Status: complete (2026-07-10).

- [`critter-stack-package-refresh.md`](./critter-stack-package-refresh.md) — **`tidy: packages` maintenance detour.** Bumped the WolverineFx family **6.8.0 → 6.17.0** (Marten 9.14.0, JasperFx 2.24.1, Weasel 9.16.2 flowing transitively; Alba already latest), discharging the "full-suite 6.x refresh still owed" item tracked since PR #35. Minor-line drop-in: restore + build green with **zero code changes**; **CI full suite 11/11 passing** (PR #41). Local test run was blocked by a wedged Docker Desktop engine (Testcontainers container `start` hangs before any app code runs); pushed to CI as the authoritative test gate rather than fighting local Docker — the same 11 tests passed in 13s in the clean CI environment. Null spec delta (dependency bump amends no canonical spec). No prompt doc — direct user request. Status: complete (2026-07-10).

Phase 1–3 retrospectives were not authored at the time those phases ran (the retrospective convention solidified during Phase 4). They may be reconstructed from the working transcripts and skill artifacts if needed; otherwise they remain a known gap in the project record.

### Per-skill retros (`skills/`)
Expand Down
48 changes: 48 additions & 0 deletions docs/retrospectives/critter-stack-package-refresh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Retrospective — Critter Stack Package Refresh

- **Trigger:** Direct user request (a "detour" ahead of the next layer-decision follow-up) to update the Critter Stack packages and run a full build + test. No prompt document — a small, well-scoped maintenance task.
- **Status:** Complete (2026-07-10).
- **Output artifacts:** [`Directory.Packages.props`](../../Directory.Packages.props) (WolverineFx family 6.8.0 → 6.17.0). This retro.
- **Outcome:** Clean minor-line refresh — build green with zero code changes; **CI full suite 11/11 passing** on the new versions. Discharges the "full-suite 6.x refresh still owed" item tracked since PR #35.

## Framing

Since the Grpc/Polecat version island was closed to 6.8 (PR #35), a full-suite refresh of the Critter Stack packages to the current 6.x line had been owed but not taken. This detour discharges it ahead of the first real transport build (the next Telemetry session), so that build starts from current packages rather than a stale floor.

## Outcome summary

| Package | Before | After | How pinned |
|---|---|---|---|
| WolverineFx.* (9 entries) | 6.8.0 | **6.17.0** | explicit in CPM |
| Marten | — | **9.14.0** | transitive via WolverineFx.Marten |
| JasperFx | — | 2.24.1 | transitive |
| Weasel | — | 9.16.2 | transitive |
| Alba | 8.5.2 | 8.5.2 | explicit — already latest |

- **Restore:** green — resolved WolverineFx 6.17.0 + Marten 9.14.0 cleanly.
- **Build:** `dotnet build CritterCab.slnx` — 0 errors, **0 code changes**.
- **Tests:** CI (clean Linux Docker) — `Failed: 0, Passed: 11, Skipped: 0, Total: 11`. PR #41 run `29114354509`.

## What worked

- **CPM keeps the bump to one line-item family.** Only the WolverineFx.* packages are pinned; Marten/JasperFx/Weasel flow transitively, so bumping WolverineFx pulled their aligned versions automatically. No risk of pinning a Marten version out of step with the Wolverine release intends.
- **CI as the authoritative test gate when local Docker is flaky.** Rather than fight a wedged Docker Desktop, pushing the branch let the full Testcontainers-backed suite run in a clean environment — and the same 11 tests that hung locally passed in 13s there. This is the more authoritative verification regardless.
- **Diagnosing the failure locus before blaming the bump.** Every local failure was at `DispatchTestFixture.InitializeAsync()` `.StartAsync()` — before any Wolverine/Marten code runs — which correctly located the fault as Docker infra, not the version change. Confirmed three ways (warm images, Ryuk disabled, both).

## What was harder than expected

- **Local Docker Desktop was in a degraded state.** The `docker` CLI half-worked, but the .NET managed named-pipe client (`Docker.DotNet`, used by Testcontainers) hung on container `start`; even `docker rm -f` blocked. "Create works, start hangs" is the signature of a wedged engine — a restart is the fix, but that's the user's environment call. The lesson: when Testcontainers fails at container start (not app code), suspect the Docker engine and fall back to CI rather than chasing package or test-code causes.

## Methodology refinements that emerged

- **When local Testcontainers is blocked, push to CI for the test gate** instead of stalling. The clean CI Docker environment is both a workaround and the more authoritative signal. Applies to any package/infra change on this repo.

## Outstanding items / next-session inputs

- **Restart Docker Desktop before the next session that needs Testcontainers locally** (the Telemetry transport build) — the engine is currently wedged. Environmental, not code.
- **Housekeeping (not blocking):** CI annotates a **Node.js 20 deprecation** on the pinned GitHub Actions (`actions/cache@v4`, `checkout@v4`, `setup-dotnet@v4`, `upload-artifact@v4`) — a future `tidy: ci` could bump those. The pre-existing **NU1903** warning (`Microsoft.OpenApi` 2.0.0 high-severity vuln) also remains and is unrelated to this bump.
- **Forward note for the Telemetry build:** this bump moved WolverineFx to 6.17 — worth re-verifying against 6.17 whether the client-streaming auto-codegen gap recorded at 5.x/pre-6.0 (the `ReportLocations` / `IMessageBus` forward-constraint) still holds before hand-wiring.

## Spec delta — landed?

**Null (maintenance).** No narrative or workshop is amended — a dependency version bump touches no canonical spec. The verification (build + CI 11/11) is the deliverable; this retro is the record.
Loading