Skip to content

ci: fix Windows build after PR 2874 #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canepat merged 1 commit into from
Apr 25, 2025
Merged

ci: fix Windows build after PR 2874 #2876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions silkworm/sync/sync_pos_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_header_timeout", "[sync]
co_return BlockHeader{};
}));

CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
}
}
}
Expand All @@ -137,7 +137,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_td_timeout", "[sync]") {
co_return kSepoliaConfig.terminal_total_difficulty;
}));

CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
}
}
}
Expand All @@ -162,7 +162,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.insert_blocks_timeout", "[sy
co_return execution::api::InsertionResult{};
}));

CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
}
}
}
Expand Down Expand Up @@ -191,7 +191,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.get_header_hash_number_timeo
co_return payload.block_num;
}));

CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kSyncingStr);
CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kSyncingStr});
}
}
}
Expand Down Expand Up @@ -250,7 +250,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::new_payload.validate_chain_success", "[s
co_return execution::api::ValidChain{};
}));

CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == rpc::PayloadStatus::kValidStr);
CHECK(spawn_and_wait(sync_.new_payload(request, 1ms)).status == std::string{rpc::PayloadStatus::kValidStr});
}
}
}
Expand All @@ -265,7 +265,7 @@ static const rpc::ForkChoiceUpdatedRequest kInvalidForkChoiceUpdatedRequest{

TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.invalid_request", "[sync]") {
const auto request = kInvalidForkChoiceUpdatedRequest;
CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kInvalidStr);
CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kInvalidStr});
}

static const rpc::ForkChoiceUpdatedRequest kValidForkChoiceUpdatedRequest{
Expand All @@ -286,7 +286,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header1_timeout"
co_return BlockHeader{};
}));

CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kSyncingStr);
CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kSyncingStr});
}

TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header2_timeout", "[sync]") {
Expand All @@ -304,7 +304,7 @@ TEST_CASE_METHOD(PoSSyncTest, "PoSSync::fork_choice_updated.get_header2_timeout"
co_return BlockHeader{};
}));

CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == rpc::PayloadStatus::kSyncingStr);
CHECK(spawn_and_wait(sync_.fork_choice_updated(request, 1ms)).payload_status.status == std::string{rpc::PayloadStatus::kSyncingStr});
}

} // namespace silkworm::chainsync
Loading