Replace removeExpression() and setExpression() use - fixes IE8,IE9,IE10 bugs#58
Open
robmckinnon wants to merge 1 commit intoericmmartin:masterfrom
robmckinnon:master
Open
Replace removeExpression() and setExpression() use - fixes IE8,IE9,IE10 bugs#58robmckinnon wants to merge 1 commit intoericmmartin:masterfrom robmckinnon:master
robmckinnon wants to merge 1 commit intoericmmartin:masterfrom
robmckinnon:master
Conversation
robmckinnon
commented
Sep 5, 2014
robmckinnon
commented
- removeExpression() and setExpression() are not supported in IE8, IE9, IE10
- This was causing simplemodal plugin not to work in IE8, IE9, IE10
- Applied patch that is documented here: http://www.ericmmartin.com/simplemodal-1-4-4-released/#comment-73180
- Remote testing via browserstack of affected IE versions shows fix works
…ons are not supported in IE8, IE9, IE10
|
You should check closed issues / pull request before working on projects. See pull request #34 that never was merged! |
This was referenced Sep 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.