Replaced HTML does not trigger modal close for elements with closeClass#17
Open
danshultz wants to merge 1 commit intoericmmartin:masterfrom
Open
Replaced HTML does not trigger modal close for elements with closeClass#17danshultz wants to merge 1 commit intoericmmartin:masterfrom
danshultz wants to merge 1 commit intoericmmartin:masterfrom
Conversation
If the html is late loaded into the modal or the html in the modal is changed, elements with the close class do not trigger close as the event is bound directly to the element vs the container element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the html is late loaded into the modal or the html in the modal is changed, elements with the close class do not trigger close as the event is bound directly to the element vs the container element.
Since I was unsure what versions of jQuery you were supporting I used$.delegate vs $ .on but please let me know if you prefer this to be changed to $.on
Thanks,
Dan