Open
Conversation
Owner
|
Hi Matt! Thanks a bunch for this submit! I will integrate it tomorrow as I have other tasks planned on this plug in as well. I'll look into your dictionary usage! Cheers Eric |
Author
|
Bump! |
Owner
|
Oops, I guess "tomorrow" wasn't exactly true :/ I'll look into it again in the following days Thanks |
Author
|
bump |
|
Ping, are you going to integrate this change? |
ptekchand
added a commit
to ptekchand/Sublime-Text-2-Perforce-Plugin
that referenced
this pull request
Jun 20, 2014
Pull request ericmartel#13: p4v commands added to context menu
Open
|
I've submit pull request #36 which fixes the merge conflicts and fixed a bug in the p4port value of the generated p4v command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heyo,
Thanks for starting out this Perforce plugin. Makes life much easier.
This pull adds three commands to the interface:
History,Time Lapse, andRevision Graph. All three use p4v to load a single window for the current file. The new command that all three of these use accepts an argument for which p4v window to load, so one could easily add another command that loads a different p4v window by invoking a different argument (e.g. "properties"). I limited the addition to these three because I've found them to be the only useful ones.It also extracts all values in
p4 infointo a dictionary. This could replace other functions such as GetUserFromClientspec() and GetClientRoot(), but I did not modify those in order to keep this pull request solely as an addition to existing code instead of a modification.Let me know if there are any changes I should make. Thanks!