Open
Conversation
Some ffi tests depend on the pointer size. Added a variant for 32bit architectures. The conditional build for 32bit architectures is intentionally done on `not(target_pointer_width = "64")` so the test is not silently skipped on architectures with other pointer sizes. In case somebody really wants to use zmq-sys on 16 bit architectures, the test will fail and another variant for that pointer size would have to be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ffi tests depend on the pointer size. Added a variant for 32bit
architectures.
The conditional build for 32bit architectures is intentionally done on
not(target_pointer_width = "64")so the test is not silently skippedon architectures with other pointer sizes. In case somebody really wants
to use zmq-sys on 16 bit architectures, the test will fail and another
variant for that pointer size would have to be added.