[pull] main from vercel:main - #537
Merged
Merged
Conversation
…duplicate step IDs (#3795) * fix(builders): dedupe pnpm peer-variant copies instead of failing on duplicate step IDs When pnpm resolves the same package version into multiple virtual-store instances (one per peer-dependency resolution), each instance is a byte-identical copy of the same module that generates the same canonical step/workflow ID. The duplicate-ID check treated these as a fatal collision, failing builds for apps whose dependency graphs pull in two peer variants of the Workflow SDK (or any step-defining package). The duplicate-ID check now fingerprints (SHA-256) the source of each file that contributes manifest entries. When two different files emit the same ID for the same symbol and their contents are identical, the registration is deduplicated and the build continues. Files with differing contents still fail with the existing collision error. Content hashing is used rather than realpath()/inode identity because pnpm materializes virtual instances via hard links (Linux) or clones/copies (macOS APFS), neither of which realpath resolves and the latter of which allocates fresh inodes. The previously duplicated merge/assert logic in swc-esbuild-plugin.ts and base-builder.ts is consolidated into a shared manifest-ids.ts. * Update .changeset/dedupe-pnpm-peer-variant-step-ids.md Co-authored-by: Peter Wielander <mittgfu@gmail.com> Signed-off-by: Nathan Rajlich <n@n8.io> --------- Signed-off-by: Nathan Rajlich <n@n8.io> Co-authored-by: Peter Wielander <mittgfu@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )