Move adapters to independent subpackages - #744
Draft
pinkwah wants to merge 1 commit into
Draft
Conversation
pinkwah
marked this pull request as draft
June 17, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft on moving adapters into individual subpackages. ~1 adapter per (both versions of arcs share the same pacakge).
Each package is individualised, and we have a test that ensures that each package's tests are ran without the others being present.
One wrinkle right now is that a few of the models require us to specify remote URLs, which means we can't put that config into acidwatch's main
Settingsobject.To install all subpackages, run
uv sync --all-packages. Otherwise uv will only install the backend. I figure I'll add aACIDWATCH_ENABLED_ADAPTERSandACIDWATCH_DISABLED_ADAPTERSto easier control which ones are on.