chore(test): replaced httpmock by (already used) wiremock#3342
Draft
chore(test): replaced httpmock by (already used) wiremock#3342
Conversation
CHr15F0x
reviewed
Apr 15, 2026
vbar
force-pushed
the
vbar/httpmock-to-wiremock
branch
from
7921567 to
6a1e0d9
Compare
CHr15F0x
reviewed
Apr 16, 2026
| /// [StarknetError](starknet_gateway_types::error::StarknetError) for a | ||
| /// given [KnownStarknetErrorCode]. | ||
| /// | ||
| /// The response tuple can then be used by the [setup] function. |
Contributor
There was a problem hiding this comment.
setup is no more - right?
CHr15F0x
approved these changes
Apr 16, 2026
Contributor
CHr15F0x
left a comment
CHr15F0x
left a comment
There was a problem hiding this comment.
LGTM % (the docs nit && gateway-test-utils source should be git-rm'ed from the source tree).
Contributor
Author
Yes, once it's replaced in |
Contributor
Sorry! I rushed on a still-a-draft PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed crate
gateway-test-utils.Closes #3325.