Skip to content

Fix HomeMatic Script injection in hmscript_escapeString #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claymore666 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix HomeMatic Script injection in hmscript_escapeString #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions WebUI/www/api/eq3/hmscript.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ proc hmscript_runFromFile { filename {p_args -}} {
}

proc hmscript_escapeString { str } {
# Backslash MUST be escaped first, otherwise a backslash placed directly
# before a quote in user input would (after the quote is escaped to \")
# be read by ReGa as an escaped backslash, closing the string literal
# early and turning the rest of the input into executable HomeMatic Script.
return [string map {
"\\" "\\\\"
"\'" "\\\'"
"\"" "\\\""
"\n" "\\n"
Expand Down