feat: Create coinbase-advanced rest plugin #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nger functional, as Coinbase Pro no longer exists and the old rest api requires different authentication.
…egged value for now for handling cases where Coinbase hasn't provided us with more specific values when calculating spot prices.
… coinbase_advanced rest plugin. This is to simplify setup and provide some additional security to users.
…base_advanced rest api
Author
|
What else is needed to get this merged in? I see Documentation Check errors with broken links, but those links don't appear to be related to changes in this PR. I believe I've fixed all errors reported by pylint. Some warnings and convention level messages remain and I could resolve a few of those, but a few I disagree with, too. Does this project treat pylint warnings as a cause for static analysis failure, or are there errors that I didn't see in the log? |
…ipping broken link detection on Binance URLs, as they are blocked by certain jurisdictions.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new coinbase_advanced rest plugin. The old plugins are no longer functional, as Coinbase Pro no longer exists and the old rest api requires different authentication.
This also includes a change to the "coinbase_advanced" spot price retrieval plugin, as it was failing due to Coinbase's introduction of USDC without providing a USDC/USD product-id/lookup.
A Dockerfile is included in case security-conscious users want to run in a sandbox and also because the new rest plugin requires the Coinbase Rest Client, which this Dockerfile auto-installs.