Skip to content

Conversation

@crod951
Copy link
Collaborator

@crod951 crod951 commented Feb 27, 2025

  1. Updated elixir to 1.18.2
  2. Updated erlang to 27.2.4
  3. Updated all non-breaking dependencies that were out of date
  4. Resolved readability issue with credo

Copy link
Member

@akinsey akinsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is actually breaking the tests or not, but it seems to be?

When i try to run this locally I cannot login, I get the following error:

 (UndefinedFunctionError) function GuardianRedis.Repo.insert/2 is undefined (module GuardianRedis.Repo is not available)

let me know if you are able to reproduce, thanks!

@crod951
Copy link
Collaborator Author

crod951 commented Feb 28, 2025

Not sure if this is actually breaking the tests or not, but it seems to be?

When i try to run this locally I cannot login, I get the following error:

 (UndefinedFunctionError) function GuardianRedis.Repo.insert/2 is undefined (module GuardianRedis.Repo is not available)

let me know if you are able to reproduce, thanks!

@akinsey good catch, I think my setup was in a weird spot with updating the dependencies that the tests were passing, after restarting and recompiling everything, I got the same error. thanks for letting me know. the next commits will fix this issue

Copy link
Member

@akinsey akinsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@akinsey akinsey merged commit dd58fb6 into main Feb 28, 2025
5 checks passed
@akinsey akinsey deleted the update-deps branch February 28, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants