This repository was archived by the owner on Jan 28, 2024. It is now read-only.
Add functionality to send message to channel after connecting #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(!empty($msg)) | ||
| { | ||
| $this->msg($msg); | ||
| $this->listen(true); |
There was a problem hiding this comment.
I think this conditional can be simplified to something more like:
if (!empty($msg)) {
$this->msg($msg)
}
$this->listen(true)
|
Thanks for the PR! I've had a few people ask for functionality like this, so this is great. I made a few comments on the commit. When you get a sec, review my comments and let me know what you think. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to broadcast message to specified channel after connection and disconnect after successfully send