extensibility modifications #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ignore] modified epi-repository ptotcol to http
…s they are all explicit dependencies of sub modules
…low for extension
…xt application attribute to VelocityEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to allow the elda-extension module (https://github.com/rwalpole/elda-extension) to continue working with the latest version of Elda. The main changes are access modifications to two methods to allow access from subclasses and some dependency modifications to allow the extension module to take dependency versions etc. directly from the elda pom.xml. This includes adding a dependencyManagement block to the project pom.xml and moving some specific dependencies of elda-lda from the project pom to the elda-lda pom.