Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 2, 2025

This PR removes the temporary JAX version constraint that was preventing installation of JAX >= 0.7.

Background

In PR #103, we temporarily constrained JAX to jax<0.7 due to a compatibility issue with distrax library (google-deepmind/distrax#295). The constraint was added to prevent breaking changes while the distrax team resolved the compatibility issue.

Changes

  • Updated requirements.txt to remove the version constraint, changing jax<0.7 # 0.7 breaks distrax to simply jax
  • This allows installation of JAX 0.7+ now that the distrax compatibility issue has been resolved

Verification

  • Confirmed that pip install jax --dry-run successfully resolves to JAX 0.7.1
  • Verified that distrax is still used throughout the codebase (in examples and models), confirming this change is important for compatibility
  • No other files contained references to the old constraint

This change enables users to install the latest JAX versions while maintaining compatibility with distrax and other dependencies.

Fixes #104.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Sep 2, 2025

@epignatelli 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

@Copilot Copilot AI changed the title [WIP] Relax constraint on jax<0.7 Relax JAX constraint from jax<0.7 to jax Sep 2, 2025
@Copilot Copilot AI requested a review from epignatelli September 2, 2025 13:50
Copilot finished work on behalf of epignatelli September 2, 2025 13:50
Copy link
Owner

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to manually increase the version number of NAVIX also.

@github-project-automation github-project-automation bot moved this to Changes requested in Navix roadmap Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

************* Module navix._version
navix/_version.py:1:0: C0114: Missing module docstring (missing-module-docstring)


Report
======
2 statements analysed.

Statistics by type
------------------

+---------+-------+-----------+-----------+------------+---------+
|type     |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module   |1      |NC         |NC         |0.00        |0.00     |
+---------+-------+-----------+-----------+------------+---------+
|class    |0      |NC         |NC         |0           |0        |
+---------+-------+-----------+-----------+------------+---------+
|method   |0      |NC         |NC         |0           |0        |
+---------+-------+-----------+-----------+------------+---------+
|function |0      |NC         |NC         |0           |0        |
+---------+-------+-----------+-----------+------------+---------+



24 lines have been analyzed

Raw metrics
-----------

+----------+-------+------+---------+-----------+
|type      |number |%     |previous |difference |
+==========+=======+======+=========+===========+
|code      |3      |12.50 |NC       |NC         |
+----------+-------+------+---------+-----------+
|docstring |0      |0.00  |NC       |NC         |
+----------+-------+------+---------+-----------+
|comment   |15     |62.50 |NC       |NC         |
+----------+-------+------+---------+-----------+
|empty     |6      |25.00 |NC       |NC         |
+----------+-------+------+---------+-----------+



Duplication
-----------

+-------------------------+------+---------+-----------+
|                         |now   |previous |difference |
+=========================+======+=========+===========+
|nb duplicated lines      |0     |NC       |NC         |
+-------------------------+------+---------+-----------+
|percent duplicated lines |0.000 |NC       |NC         |
+-------------------------+------+---------+-----------+



Messages by category
--------------------

+-----------+-------+---------+-----------+
|type       |number |previous |difference |
+===========+=======+=========+===========+
|convention |1      |NC       |NC         |
+-----------+-------+---------+-----------+
|refactor   |0      |NC       |NC         |
+-----------+-------+---------+-----------+
|warning    |0      |NC       |NC         |
+-----------+-------+---------+-----------+
|error      |0      |NC       |NC         |
+-----------+-------+---------+-----------+



% errors / warnings by module
-----------------------------

+---------------+------+--------+---------+-----------+
|module         |error |warning |refactor |convention |
+===============+======+========+=========+===========+
|navix._version |0.00  |0.00    |0.00     |100.00     |
+---------------+------+--------+---------+-----------+



Messages
--------

+-------------------------+------------+
|message id               |occurrences |
+=========================+============+
|missing-module-docstring |1           |
+-------------------------+------------+




-----------------------------------
Your code has been rated at 5.00/10

@epignatelli epignatelli marked this pull request as ready for review September 3, 2025 13:26
@epignatelli epignatelli self-requested a review September 3, 2025 13:26
Copy link
Owner

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epignatelli epignatelli merged commit 7c438e9 into main Sep 3, 2025
7 checks passed
@epignatelli epignatelli deleted the copilot/fix-104 branch September 3, 2025 13:26
@github-project-automation github-project-automation bot moved this from Changes requested to Done in Navix roadmap Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Relax constraint on jax<0.7
2 participants