ci: Add Python 3.13 build #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Python 3.13 to versions tested in CI to ensure compatibility with the Numpy deprecation policy
mdavidsaver
reviewed
May 20, 2025
| @@ -119,12 +119,12 @@ def get_numpy_include_dirs(): | |||
| author='Michael Davidsaver', | |||
| author_email='[email protected]', | |||
| license='BSD', | |||
| license_files=["LICENSE"], | |||
There was a problem hiding this comment.
Any chance that this change is related to the error I now see from GHA runs?
python -m twine check dist/p4p*.whl
shell: /usr/bin/bash -e {0}
...
Checking dist/p4p-4.2.0-cp36-cp36m-manylinux1_i686.whl: ERROR InvalidDistribution: Invalid distribution metadata: unrecognized or
malformed field 'license-file'
There was a problem hiding this comment.
Looks like it's some combination of build versions, testing some fixes
There was a problem hiding this comment.
I have pushed ab76714 to fix the issue with actions/upload-artifact@v4 name uniqueness.
Reading through this twine, it isn't clear to me if this issue with the packaging module is with the P4P build, or with twine check? If the later case, then it might be better to pull in a specific version when installing twine?
DiamondJoseph
force-pushed
the
3.13-support
branch
from
8618b6f to
a54cf87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Python 3.13 to versions tested in CI to ensure compatibility with the Numpy deprecation policy