Only strip trailing dots and spaces on Windows#21
Open
ElCruncharino wants to merge 1 commit into
Open
Conversation
NormalizeFileName() removed trailing dots and spaces from every path component on all platforms, but that restriction only applies to Windows filesystems. On Linux and macOS it silently mangled folder and file names ending in a dot (e.g. "Bach J.S." became "Bach J.S").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NormalizeFileName() stripped trailing dots and spaces from every path
component on all platforms, but that restriction only applies to
Windows filesystems. On Linux and macOS it silently mangled folder and
file names ending in a dot, e.g. "Bach J.S." became "Bach J.S".
Gate the stripping behind WIN32, matching the rest of this file's
platform-specific handling.
Closes #600, Closes #718