[tap-chargebee] - review and rework PR#113#14
Open
romilqlik wants to merge 86 commits intoenvoy:masterfrom
Open
[tap-chargebee] - review and rework PR#113#14romilqlik wants to merge 86 commits intoenvoy:masterfrom
romilqlik wants to merge 86 commits intoenvoy:masterfrom
Conversation
…mments) added, changes in bookmark_date updation
Add Credit Notes Stream
* remove max length constraint * bump to 0.0.5 * update base stream * update child object streams * bump to 0.0.6 * update metadata and stream properties * dump tap-framework dependency
…added promotional credits
* new streams(coupon_sets, coupon_codes, orders, gifts, creditnotes, comments) added, changes in bookmark_date updation * Continuing to other streams incase order stream is not enabled * removed comments, coupon_sets, coupon_codes * Added Orders, Gifts, Creditnotes in ReadMe * removed SELECTED=true, added REPLICATION_METHOD, REPLICATION_KEY and added promotional credits * reverted replication method to INCREMENTAL * promotional credit bookmark key changes * gift schema changes, order schema changes * Hard delete handling by reading events * removed selected-by-default
* added more objects in events content * added coupon sets and codes * Clean up whitespace in events.json
* TDL-6287: Updated addon schema to collect missing fields * TDL-6287: Updated addon code for event stream. Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com> Co-authored-by: Kyle Allan <KAllan357@gmail.com>
…#63) * TDL-13802:Updated integration test to cover product catalog v1 and v2 * Updated test * Updated date in start_date case for passing test Co-authored-by: Kyle Allan <KAllan357@gmail.com>
* TDL-6342: add additional fields from API and make invoices and promotional_credit common stream * Added fields in item_families and subscriptions stream * Updated start_date case to pass integration test * Deleted promotional_credits from item_model as it moves to common
* TDL-13904: Upgraded event stream schema. * TDL-13904: Restructured events.json stream * TDL-13904: Updated events stream schema * TDL-13904: Removed maximum and minimum * TDL-13904: Added coments and doc string * TDL-13904: comments grammer updated Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com> Co-authored-by: Kyle Allan <KAllan357@gmail.com>
* TDL-6173: Updated Bookmark handling, date without tz will updated in UTC tz formate. * TDL-6173: Wrong format start date isn't supported in stitch hence removed that test * TDL-6173: Revert back the bookmarking logic changed by chargebee team * TDL-6173: Added start date format check * TDL-6173: Added Unittest to test wrong formate of start date * TDL-6173: Updated readme file * TDL-6173: Unit test updated * TDL-6173: Verify the start_date format in discover mode as well. * TDL-6173: Updated Unittest Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com>
* Add MANIFEST.in * Bump to v1.2.1, update changelog Co-authored-by: Andy Lu <andy@stitchdata.com>
* Update schema glob in MANIFEST.in * Bump to v1.2.2, update changelog
* TDL-6624: Added comments stream * TDL-6624: Changed record comparison in start date test. * TDL-6624: Taken lates test case changes * TDL-6624: Updated json of test * TDL-6624: Updated schema of comment stream * response to feedback * Add newline to file Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com> Co-authored-by: Zach Harris <zharris@talend.com>
* TDL-13631: Added include_deleted configuration * TDL-13631: Added Check for include_deleted * TDL-13631: Updated the test name * TDL-13631: Updated test name * TDL-13631: CHange in if condition * Fix tests * Fix include_delete test * TDL-13631: Updated test so it can run on both versions * TDL-13631: Upgraded test case. * TDL-13631: Updated integration test * TDL-13631: Updated test * TDL-13631: Updated test. * TDL-13631: Enhnaced test Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com> Co-authored-by: Andy Lu <andy@stitchdata.com> Co-authored-by: zachharris1 <69470481+zachharris1@users.noreply.github.com>
…from API doc. (#69) * Added missing additional fields * Added missing field in events schema * Added remaining fields for item_prices stream * Added missing fields which are not present in doc but found in testing * Added missing fields for event's content and subscription * Added extra type string for items and item_prices * Updated customer and subscription schema * Updated invoice schema Co-authored-by: zachharris1 <69470481+zachharris1@users.noreply.github.com>
* error handling for product catalog version API * added API response log * GEN-763 Added Quotes Object for Syncing to Stitch * case insensitive comparison of site name * Missed comma Co-authored-by: cb-akashpandey <84072472+cb-akashpandey@users.noreply.github.com> Co-authored-by: cb-prasanna <sairam@chargebee.com>
* bump 1.3.1 * add quotes to tests * skip quotes stream in test
* Added calls to generate events * Update test
* reverted bookmark logic * updated the code to take minimum of max replication key and now - 2 min as bookmark * added unittests
* TDL-19099: Add missing tap-tester tests (#83) * inital commit: add missing tap tester tests * updated the code to get event_type for events stream before transform * updated integration tests * resolve review comments * resolve integration test failure * added all fields comments * updated tap tester tests * removed pylint disable statement * updated config.yml file * fixed event_type error * updated comment * addressed review comments * updated config.yml file and start date test * TDL-16315: Implement request timeout (#78) * Added request timeout * Updated config.yml * Updated readme file * Added backoff for connectionError * updated test cases Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-19101: Add custom exception handling (#85) * Added custom exception handling * Added unit tests * Updated config.yml to cover unit test report * Added condition to handle status code other than 4xx 5xx * Added condition to handle status code other than 4xx 5xx * Added/updated unit tests * Added existing unit tests * Resolved review comment * Fixed unit test * Resolved review comment * Removed redundent Server429Error Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-19489: Revert back bookmark logic (#88) * TDL-16367: Fix pagination test failure (#79) * Added calls to generate events * Update test * TDL-19270: Revert back bookmarking logic (#86) * reverted bookmark logic * updated the code to take minimum of max replication key and now - 2 min as bookmark * added unittests * Bump version * reverted bookmark logic Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: KrishnanG <kgurusamy@talend.com> * TDL-19102: Add missing fields to schema (#87) * inital commit: add missing tap tester tests * updated the code to get event_type for events stream before transform * updated integration tests * resolve review comments * resolve integration test failure * added all fields comments * added missing and new fields in the schema * updated tap tester tests * removed pylint disable statement * updated config.yml file * fixed event_type error * updated comment * addressed review comments * updated config.yml file and start date test * updated test cases as per missing fields * updated bookmark test * resolved bookmark test failure Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: KrishnanG <kgurusamy@talend.com>
Co-authored-by: RushiT0122 <rtodkar@stitchdata-talend.com>
* add missing customer details * update integration tests --------- Co-authored-by: RushiT0122 <rtodkar@stitchdata-talend.com>
tax_rate can't be stored as an integer because many states allow fractional tax rates This change makes it match `credit_notes.json` (which stores correctly as a float) Co-authored-by: Wynn Slater <armordog@gmail.com>
Co-authored-by: RushiT0122 <rtodkar@stitchdata-talend.com>
* Update subscription schema to include manual discounts. * Fixed All fields integration tests. * Fixed All fields integration tests. * Fixed all fields & pagination tests. * Fixed All fields integration test. * minor bump 1.4.0 (#110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change:
Updated setup.py with the latest secure versions of core dependencies:
singer-python==6.1.1
requests==2.32.3
backoff==2.2.1
simplejson==3.20.1
Verified local functionality of payment_sources stream via discovery mode
Confirmed schema file (schemas/payment_sources.json) aligns with catalog
Ensured tap runs successfully with valid credentials and configuration
Manual QA steps:
Confirm presence of "payment_sources" stream in catalog.json
Compare discovered schema with schemas/payment_sources.json
Risks:
CI tests fail due to Chargebee test site being inactive (403 Site not enabled); actual tap functionality is unaffected
Rollback steps:
Push rollback branch or revert PR