ERSAD: Update shelter or waiting room availability logic#1659
Merged
a-limyr merged 4 commits intoentur:masterfrom Feb 10, 2026
Merged
Conversation
solita-sabinaf
changed the title
solita-sabinaf
force-pushed
the
TIS-1235/update_shelter_or_waiting_room_availablity_logic
branch
from
72e9996 to
6067bb1
Compare
testower
reviewed
Feb 5, 2026
src/static/lang/fr.json
Outdated
| "not_assigned": "N/R", | ||
| "number_of_seats": "Nombre de places assises", | ||
| "seats": "Places assises disponibles", | ||
| "seats": "Places assises indisponibles", |
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching it! The second was supposed to be seats_no
testower
requested changes
Feb 5, 2026
Contributor
testower
left a comment
testower
left a comment
There was a problem hiding this comment.
Just one issue with the french translation keys, otherwise lgtm
Collaborator
Author
|
The needed change got added 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explain in one or two sentences what this PR achieves.
Issue
Update shelter or waiting room availability logic, so that it no longer checks the value of number of seats.
Closes #1658
Unit tests
Write a few words on how the new code is tested.