ERSAD: Add information display and information desk inputs by solita-sabinaf · Pull Request #1652 · entur/abzu

solita-sabinaf · 2025-12-30T14:33:15Z

Summary

In facilities tab: new information display input.
In assistance tab: new information desk input.

Both are defined on a stop place level only.

Issue

We need these to support these ERSAD fields;
The implementation just extends the current site facility set with two new fields: passengerInformationEquipmentList and passengerInformationFacilityList. Nothing special;
Two new components were added, InformationDesk and PassengerInformationDisplay, to handle these new inputs;

The XML behind:

<facilities>
	<SiteFacilitySet id="FSR:SiteFacilitySet:510" version="1">
            <MobilityFacilityList>boardingAssistance</MobilityFacilityList>
            <PassengerInformationEquipmentList>informationDesk</PassengerInformationEquipmentList>
            <PassengerInformationFacilityList>passengerInformationDisplay</PassengerInformationFacilityList>
	</SiteFacilitySet>
</facilities>

Unit tests

Unit tests added/updated
Manual verification done

a-limyr

This is a well-structured implementation that follows established patterns. The code is clean, properly integrated across all layers and moves the application towards TypeScript. I found a type issue and some other minor things that might not be an issue.

Good job!

a-limyr · 2026-01-12T10:40:55Z

src/models/Facilities.ts

 export interface SiteFacilitySet {
  mobilityFacilityList: MobilityFacility[];
+  passengerInformationFacilityList: PassengerInformationFacility[];
+  passengerInformationEquipmentList: PassengerInformationEquipment | null;


Is this supposed to be a list also? If not then perhaps the name should be passengerInformationEquipment?

Good catch! This was originally due to backend's netex model (part that is bound to external library) having it as a single value (despite name suggesting it's a list), but since in the end I made it so that tiamat's own netex model has it as a real list, I think I forgot to tune up this spot along

a-limyr · 2026-01-12T10:44:50Z

src/modelUtils/facilitiesHelpers.js

        }
      : { ...defaultSiteFacilitySet, ...state };
    updatedEntity.quays[id].facilities = [newSiteFacilitySet];
+  } else {


Would it be an idea to have a else if here to verify that the type is stopPlace? And not just assume? At least it would be more readable.

Not sure, the "entity" usually implied that it's either a quay or stopPlace (e.g. type EntityType in model), so if a method was about updating an entity, maybe there aren't other use cases coming around 🤔 But then I do remember that in the UI components there been some places where the value of "type" that can be a "parking"...

But maybe for the sake of readability "else if" would make it more clear, I'll add it

a-limyr · 2026-01-12T10:50:25Z

src/models/Facilities.ts

+  STOP_TIMETABLE = "stopTimetable",
+  JOURNEY_PLANNING = "journeyPlanning",
+  INTERACTIVE_KIOSK = "interactiveKiosk",
+  INFORMATION_DESK = "informationDesk",


This is the only enum in use from this set of enums. Is this intentional or have you forgotten to add support for the other enums in the UI? If it is there for future implementations it is fine.

These just tagged along from the backend, could be used in future (currently only info desk is) but not yet (and probably won't be done by us)

a-limyr · 2026-01-12T10:50:58Z

src/models/Facilities.ts

+export enum PassengerInformationFacility {
+  NEXT_STOP_INDICATOR = "nextStopIndicator",
+  STOP_ANNOUNCEMENTS = "stopAnnouncements",
+  PASSENGER_INFORMATION_DISPLAY = "passengerInformationDisplay",


This is the only enum in use from this set of enums. Is this intentional or have you forgotten to add support for the other enums in the UI? If it is there for future implementations it is fine.

These just tagged along from the backend, could be used in future (currently only passengerInformationDisplay is) but not yet (and probably won't be done by us)

solita-sabinaf · 2026-01-14T10:51:26Z

@a-limyr, thank you for the review, great points! The changes been made, I'll ping once the backend is merged

solita-sabinaf · 2026-01-21T08:39:58Z

@a-limyr, the backend is now merged 🚀

a-limyr · 2026-01-26T09:27:21Z

I have tested this. I get the UI working fine, but I have issues when I try to save changes in these fields I get the following error from Tiamat:
{ "data": { "mutateStopPlace": null }, "errors": [ { "message": "Exception while fetching data (/mutateStopPlace) : Cannot invoke \"java.util.List.isEmpty()\" because \"mobilityFacilityListInput\" is null", "errorType": "DataFetchingException", "locations": [ { "line": 2, "column": 3, "sourceName": null } ], "path": null, "extensions": null } ] }

Any idea why this is happening?

solita-sabinaf · 2026-01-29T09:16:23Z

Thank you for catching this! I think I may have introduced a small bug in the last round of the after-review changes in the Tiamat's PR for this feature. I pushed a fix, will ping once it's merged 🚀

solita-sabinaf · 2026-02-02T11:17:59Z

@a-limyr the backend fix for this has now been merged! 🚀

Add information display and information desk

9150bd9

a-limyr self-requested a review January 12, 2026 10:34

a-limyr reviewed Jan 12, 2026

View reviewed changes

Improve some small things in Facilities model and helpers

1df57f4

a-limyr merged commit 26029bf into entur:master Feb 5, 2026
1 check passed

Conversation

solita-sabinaf commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Issue

Unit tests

Uh oh!

a-limyr left a comment

Choose a reason for hiding this comment

Uh oh!

a-limyr Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

solita-sabinaf Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a-limyr Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

solita-sabinaf Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solita-sabinaf Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

a-limyr Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

solita-sabinaf Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

a-limyr Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

solita-sabinaf Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

solita-sabinaf commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solita-sabinaf commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

a-limyr commented Jan 26, 2026

Uh oh!

solita-sabinaf commented Jan 29, 2026

Uh oh!

solita-sabinaf commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

solita-sabinaf commented Dec 30, 2025 •

edited

Loading

solita-sabinaf Jan 14, 2026 •

edited

Loading

solita-sabinaf Jan 14, 2026 •

edited

Loading

solita-sabinaf commented Jan 14, 2026 •

edited

Loading

solita-sabinaf commented Jan 21, 2026 •

edited

Loading