Route the crop_resize ISA checks through yscv-cpu - #28
Closed
enthropy7 wants to merge 1 commit into
Closed
Conversation
`check-runtime-dispatch.sh` has been failing on main since the SSE4.1 and AVX-512 crop_resize paths landed: six raw `std::is_x86_feature_detected!` calls in the bit-exactness tests. The guard exists so feature detection has one home, and the surrounding production dispatch in this same file already goes through `yscv_cpu::host_cpu().features`. GitHub CI does not run this script, which is why it went unnoticed.
Owner
Author
|
Closing — landing directly on main instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-runtime-dispatch.shhas been red on main since the SSE4.1/AVX-512 crop_resize paths landed — six rawstd::is_x86_feature_detected!calls in the bit-exactness tests. The production dispatch in the same file already usesyscv_cpu::host_cpu().features; the tests now do too.GitHub CI does not run this script, only
check-ci-local.shdoes, which is why it went unnoticed.check-ci-local.shnow exits 0. imgproc suite 247 passed.