Move MouseClick to a separate interaction for simple instance editor#1212
Merged
kitchoi merged 4 commits intoui-tester-updates-InstanceEditorfrom Sep 15, 2020
Merged
Conversation
…-ui-instance-editor
| instance = tester.find_by_name(ui, "inst") | ||
| instance.perform(command.MouseClick()) | ||
|
|
||
| value_txt = tester.find_by_name(ui, "inst").find_by_name("value") |
Contributor
There was a problem hiding this comment.
could we do value_txt =instance.find_by_name("value") here?
aaronayres35
approved these changes
Sep 14, 2020
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
Changes LGTM! Just one small comment
…com/enthought/traitsui into ui-tester-nested-ui-instance-editor
aaronayres35
added a commit
that referenced
this pull request
Sep 15, 2020
* initial instance editor implementations (just find nested uis). Note that I had to make a change to wx isntance editor itself to access ui - this idea was taken from Kits draft branch * replacing one old test * update test - we need ui_base to do a full replacement * adding more tests * flake8 * adding docstrings * fix netsed typo * Move MouseClick to a separate interaction for simple instance editor (#1212) * Move MouseClick to a separate interaction for simple instance editor * Reuse the wrapper already available Co-authored-by: aaronayres35 <36972686+aaronayres35@users.noreply.github.com> * making suggested change * flake8 Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeting #1208
This PR is intended to accompany my review comments... it does not need to be merged but if @aaronayres35 is happy with this to be merged to #1208, please feel free to review and I will address review comments accordingly.