Draft implementation for various UITester features #1150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitchoi
commented
Aug 18, 2020
Comment on lines
+242
to
+244
| editor : Editor | ||
| An instance of Editor. It is assumed to be in a state after the UI | ||
| has been initialized but before it is disposed of. |
Contributor
Author
There was a problem hiding this comment.
The editor attribute will be renamed, and it may not be an instance of traitsui Editor.
#1107 will clarify that.
kitchoi
commented
Aug 18, 2020
Comment on lines
+11
to
+12
| self.editor_to_action_to_handler = {} | ||
| self.editor_to_location_solver = {} |
Contributor
Author
There was a problem hiding this comment.
These two are independent, so we might as well have a registry for interaction, and a separate registry for locations.
This was referenced Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR which I will close immediately. This contains proof-of-concept code which I used to experiment with ways to implement the UITester. I also tested the API with a number of editors: ButtonEditor, TextEditor, ListEditor, EnumEditor, TableEditor, TreeEditor, RangeEditor as well as the UI panel specific TabbedFoldGroupEditor.
Qt/Wx toolkit compatibility was tested for ButtonEditor and RangeEditor only.
It is open for the reference of #1149.
Caution: