Skip to content

Remove macos-latest from ets-from-source workflow#1278

Merged
mdickinson merged 2 commits into
mainfrom
fix/ets-from-source-workflow
May 16, 2025
Merged

Remove macos-latest from ets-from-source workflow#1278
mdickinson merged 2 commits into
mainfrom
fix/ets-from-source-workflow

Conversation

@mdickinson

Copy link
Copy Markdown
Member

Our ets-from-source workflow is currently failing, for the simple and shallow reason that we're not currently in a position to run EDM-based tests on macOS/ARM (missing runtime for Python 3.8; missing dependencies for Python 3.11). This PR removes macos-latest from the test matrix, and makes a couple of other drive-by cleanups.

os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, windows-latest]
toolkit: ['pyside6']
runtime: ['3.8']

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added for parity with the test-with-edm workflow, and to ease adding 3.11 testing later on (when the necessary dependencies are present in EDS).

runtime: ['3.8']
timeout-minutes: 20
runs-on: ${{ matrix.os }}
env:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why this was originally necessary, but I don't think we need it any more - similar blocks have been removed in EDM-using workflows for other ETS packages.

If this removal succeeds, I'll also update in other workflows.

@mdickinson

mdickinson commented May 16, 2025

Copy link
Copy Markdown
Member Author

Workflow test run: https://github.com/enthought/pyface/actions/runs/15066753284 (successful).

@mdickinson

Copy link
Copy Markdown
Member Author

Updated with additional consistency fixes: all workflows can now be executed manually, and fail fast is restored (it was previously removed during workflow debugging, but I think that's no longer necessary).

@mdickinson mdickinson merged commit 9511063 into main May 16, 2025
28 checks passed
@mdickinson mdickinson deleted the fix/ets-from-source-workflow branch May 16, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant