Fix Index Conflict

[freephile]

When upgrading Wiretap, you will get an error when it tries
to create the unique indices that already exist. So, we
delete the indices prior to creating them in the SQL files.

[jamesmontalvo3]

update.php shouldn't run those patch files if the components they add already exist. For example, in [1] patch-2-page-counter.sql is only run if wiretap_counter_period table doesn't already exist. If for some reason it's trying to run these SQL files then something else is up.

[1]

Wiretap/Wiretap.body.php

Lines 119 to 135 in 098e344

	$updater->addExtensionTable(
	$wiretapTable,
	"$schemaDir/Wiretap.sql"
	);
	$updater->addExtensionField(
	$wiretapTable,
	'response_time',
	"$schemaDir/patch-1-response-time.sql"
	);
	$updater->addExtensionTable(
	$wiretapCounterTable,
	"$schemaDir/patch-2-page-counter.sql"
	);
	$updater->addExtensionTable(
	$wiretapLegacyTable,
	"$schemaDir/patch-3-legacy-counter.sql"
	);

[jamesmontalvo3]

@freephile did you figure out why this was running when it shouldn't have?

[freephile]

I didn't figure it out. I still get that behavior sometimes. I'll keep digging. Greg Rundlett https://eQuality-Tech.com https://freephile.org

…

On Sat, Mar 23, 2019 at 10:51 AM James Montalvo ***@***.***> wrote: @freephile <https://github.com/freephile> did you figure out why this was running when it shouldn't have? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACV4NjK07e1OnRV8d8piDHVkh9agS5qks5vZj9tgaJpZM4Z1WbD> .