fix(connectors): sweep of fixes across providers

Author: engineering87

README.md

@@ -9,7 +9,7 @@
 
 <img src="https://github.com/engineering87/SharpConnector/blob/main/sharpconnector_logo.jpg" width="300">
 
-SharpConnector is a .NET library designed to streamline integration with NoSQL databases. It provides a unified interface that simplifies database operations, eliminating the need to develop custom logic for each specific database connector. Since each NoSQL database has its own unique characteristics—such as being document-oriented or key-value-based—SharpConnector abstracts these differences, providing a consistent and simplified access layer to accelerate development.
+SharpConnector is a .NET library designed to streamline integration with NoSQL databases. It provides a unified interface that simplifies database operations, eliminating the need to develop custom logic for each specific database connector. Since each NoSQL database has its own unique characteristics, such as being document-oriented or key-value-based, SharpConnector abstracts these differences, providing a consistent and simplified access layer to accelerate development.
 
 ## Features
 
@@ -169,7 +169,7 @@ If you want to add new connectors, please follow these three rules:
  * [Fork the repository](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo)
  * [Open an issue](https://github.com/engineering87/SharpConnector/issues) if you encounter a bug or have a suggestion for improvements/features
 
-### Licensee
+### License
 SharpConnector source code is available under MIT License, see license in the source.
 
 #### External References

src/SharpConnector.Tests/ConnectorTests.cs

@@ -4,6 +4,7 @@
 using Moq;
 using SharpConnector.Interfaces;
 using System.Collections.Generic;
+using System.Threading;
 using System.Threading.Tasks;
 
 namespace SharpConnector.Tests
@@ -18,17 +19,25 @@ public ConnectorTests()
         {
             _mockClient = new Mock<ISharpConnectorClient<string>>();
 
+            // Sync setups (nessun token qui)
             _mockClient.Setup(client => client.Insert(It.IsAny<string>(), It.IsAny<string>()))
                        .Returns(true);
 
-            _mockClient.Setup(client => client.InsertAsync(It.IsAny<string>(), It.IsAny<string>()))
-                       .ReturnsAsync(true);
-
             _mockClient.Setup(client => client.Get(It.IsAny<string>()))
                        .Returns((string key) => key == "testKey" ? "payload" : null);
 
-            _mockClient.Setup(client => client.GetAsync(It.IsAny<string>()))
-                       .ReturnsAsync((string key) => key == "testKey" ? "payload" : null);
+            // Async setups: SPECIFICA SEMPRE IL CancellationToken
+            _mockClient.Setup(client => client.InsertAsync(
+                                    It.IsAny<string>(),
+                                    It.IsAny<string>(),
+                                    It.IsAny<CancellationToken>()))
+                       .ReturnsAsync(true);
+
+            _mockClient.Setup(client => client.GetAsync(
+                                    It.IsAny<string>(),
+                                    It.IsAny<CancellationToken>()))
+                       .ReturnsAsync((string key, CancellationToken _) =>
+                                        key == "testKey" ? "payload" : null);
 
             _sharpConnectorClient = _mockClient.Object;
         }
@@ -72,7 +81,7 @@ public void Get()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = _sharpConnectorClient.Get(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
         }
 
         [TestMethod]
@@ -82,7 +91,7 @@ public async Task GetAsync()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = await _sharpConnectorClient.GetAsync(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
         }
 
         [TestMethod]
@@ -92,9 +101,8 @@ public void Update()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = _sharpConnectorClient.Get(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
 
-            // Set up mock for update method
             _mockClient.Setup(client => client.Update(key, "modPayload")).Returns(true);
             var update = _sharpConnectorClient.Update(key, "modPayload");
             Assert.IsTrue(update);
@@ -107,10 +115,14 @@ public async Task UpdateAsync()
             var insert = await _sharpConnectorClient.InsertAsync(key, "payload");
             Assert.IsTrue(insert);
             var obj = await _sharpConnectorClient.GetAsync(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
+
+            _mockClient.Setup(client => client.UpdateAsync(
+                                        key,
+                                        "modPayload",
+                                        It.IsAny<CancellationToken>()))
+                       .ReturnsAsync(true);
 
-            // Mock async update behavior
-            _mockClient.Setup(client => client.UpdateAsync(key, "modPayload")).ReturnsAsync(true);
             var update = await _sharpConnectorClient.UpdateAsync(key, "modPayload");
             Assert.IsTrue(update);
         }
@@ -122,9 +134,8 @@ public void Delete()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = _sharpConnectorClient.Get(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
 
-            // Mock delete behavior
             _mockClient.Setup(client => client.Delete(key)).Returns(true);
             var delete = _sharpConnectorClient.Delete(key);
             Assert.IsTrue(delete);
@@ -137,12 +148,15 @@ public async Task DeleteAsync()
             var insert = await _sharpConnectorClient.InsertAsync(key, "payload");
             Assert.IsTrue(insert);
             var obj = await _sharpConnectorClient.GetAsync(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
+
+            _mockClient.Setup(client => client.DeleteAsync(
+                                        key,
+                                        It.IsAny<CancellationToken>()))
+                       .ReturnsAsync(true);
 
-            // Mock async delete behavior
-            _mockClient.Setup(client => client.DeleteAsync(key)).ReturnsAsync(true);
             var delete = await _sharpConnectorClient.DeleteAsync(key);
             Assert.IsTrue(delete);
         }
     }
-}
+}

src/SharpConnector.Tests/SharpConnector.Tests.csproj

@@ -27,8 +27,8 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
     <PackageReference Include="Moq" Version="4.20.72" />
-    <PackageReference Include="MSTest.TestAdapter" Version="3.10.0" />
-    <PackageReference Include="MSTest.TestFramework" Version="3.10.0" />
+    <PackageReference Include="MSTest.TestAdapter" Version="3.10.2" />
+    <PackageReference Include="MSTest.TestFramework" Version="3.10.2" />
     <PackageReference Include="coverlet.collector" Version="6.0.4">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>