Merge pull request #35 from engineering87/develop

fix(connectors): Sweep of bug fixes, async consistency, access wrappers hardening, and .NET 9 migration

Author: engineering87

.github/workflows/commit-lint.yml

@@ -7,6 +7,9 @@ on:
       - '*'  # Runs on any pull request targeting any branch
 
 name: Lint commits
+permissions:
+  contents: read
+  pull-requests: write
 jobs:
   lint-commits:
     runs-on: ubuntu-latest

.github/workflows/dotnet.yml

@@ -2,6 +2,8 @@
 # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net
 
 name: Build
+permissions:
+  contents: read
 
 on:
   push:
@@ -27,7 +29,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 8.0.x
+        dotnet-version: 9.0.x
 
     - name: Restore dependencies
       run: dotnet restore src/SharpConnector/SharpConnector.csproj

README.md

@@ -9,7 +9,7 @@
 
 <img src="https://github.com/engineering87/SharpConnector/blob/main/sharpconnector_logo.jpg" width="300">
 
-SharpConnector is a .NET library designed to streamline integration with NoSQL databases. It provides a unified interface that simplifies database operations, eliminating the need to develop custom logic for each specific database connector. Since each NoSQL database has its own unique characteristics—such as being document-oriented or key-value-based—SharpConnector abstracts these differences, providing a consistent and simplified access layer to accelerate development.
+SharpConnector is a .NET library designed to streamline integration with NoSQL databases. It provides a unified interface that simplifies database operations, eliminating the need to develop custom logic for each specific database connector. Since each NoSQL database has its own unique characteristics, such as being document-oriented or key-value-based, SharpConnector abstracts these differences, providing a consistent and simplified access layer to accelerate development.
 
 ## Features
 
@@ -130,25 +130,25 @@ Then, add the specif `ConnectorConfig` node within your *appsettings.json* file:
 	```
 
 - ArangoDB
-```json
-{
-  "ConnectorConfig": {
-    "Instance": "ArangoDb",
-    "ConnectionString": "http://localhost:8529",
-    "Username": "username",
-    "Password": "password",
-    "CollectionName": "test"
-  }
-}
-```
+	```json
+	{
+		"ConnectorConfig": {
+			"Instance": "ArangoDb",
+			"ConnectionString": "http://localhost:8529",
+			"Username": "username",
+			"Password": "password",
+			"CollectionName": "test"
+		}
+	}
+	```
 
 Once configured, create a new SharpConnector client, specifying the payload type (e.g., string):
 
 ```csharp
 SharpConnectorClient<string> client = new SharpConnectorClient<string>()
 ```
 
-Alternatively, you can integrate SharpConnector client using dependency injection. Here’s how to register the SharpConnector service with a simple string payload type:
+Alternatively, you can integrate SharpConnector client using dependency injection. Here how to register the SharpConnector service with a simple string payload type:
 
 ```csharp
 // Register the SharpConnector services with string payload type.
@@ -169,7 +169,7 @@ If you want to add new connectors, please follow these three rules:
  * [Fork the repository](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo)
  * [Open an issue](https://github.com/engineering87/SharpConnector/issues) if you encounter a bug or have a suggestion for improvements/features
 
-### Licensee
+### License
 SharpConnector source code is available under MIT License, see license in the source.
 
 #### External References

src/SharpConnector.Api/SharpConnector.Api.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
 	<IsPackable>false</IsPackable>
@@ -42,7 +42,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Swashbuckle.AspNetCore" Version="8.0.0" />
+    <PackageReference Include="Swashbuckle.AspNetCore" Version="9.0.3" />
   </ItemGroup>
 
   <ItemGroup>

src/SharpConnector.Tests/ConnectorTests.cs

@@ -4,6 +4,7 @@
 using Moq;
 using SharpConnector.Interfaces;
 using System.Collections.Generic;
+using System.Threading;
 using System.Threading.Tasks;
 
 namespace SharpConnector.Tests
@@ -18,17 +19,25 @@ public ConnectorTests()
         {
             _mockClient = new Mock<ISharpConnectorClient<string>>();
 
+            // Sync setups (nessun token qui)
             _mockClient.Setup(client => client.Insert(It.IsAny<string>(), It.IsAny<string>()))
                        .Returns(true);
 
-            _mockClient.Setup(client => client.InsertAsync(It.IsAny<string>(), It.IsAny<string>()))
-                       .ReturnsAsync(true);
-
             _mockClient.Setup(client => client.Get(It.IsAny<string>()))
                        .Returns((string key) => key == "testKey" ? "payload" : null);
 
-            _mockClient.Setup(client => client.GetAsync(It.IsAny<string>()))
-                       .ReturnsAsync((string key) => key == "testKey" ? "payload" : null);
+            // Async setups: SPECIFICA SEMPRE IL CancellationToken
+            _mockClient.Setup(client => client.InsertAsync(
+                                    It.IsAny<string>(),
+                                    It.IsAny<string>(),
+                                    It.IsAny<CancellationToken>()))
+                       .ReturnsAsync(true);
+
+            _mockClient.Setup(client => client.GetAsync(
+                                    It.IsAny<string>(),
+                                    It.IsAny<CancellationToken>()))
+                       .ReturnsAsync((string key, CancellationToken _) =>
+                                        key == "testKey" ? "payload" : null);
 
             _sharpConnectorClient = _mockClient.Object;
         }
@@ -72,7 +81,7 @@ public void Get()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = _sharpConnectorClient.Get(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
         }
 
         [TestMethod]
@@ -82,7 +91,7 @@ public async Task GetAsync()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = await _sharpConnectorClient.GetAsync(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
         }
 
         [TestMethod]
@@ -92,9 +101,8 @@ public void Update()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = _sharpConnectorClient.Get(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
 
-            // Set up mock for update method
             _mockClient.Setup(client => client.Update(key, "modPayload")).Returns(true);
             var update = _sharpConnectorClient.Update(key, "modPayload");
             Assert.IsTrue(update);
@@ -107,10 +115,14 @@ public async Task UpdateAsync()
             var insert = await _sharpConnectorClient.InsertAsync(key, "payload");
             Assert.IsTrue(insert);
             var obj = await _sharpConnectorClient.GetAsync(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
+
+            _mockClient.Setup(client => client.UpdateAsync(
+                                        key,
+                                        "modPayload",
+                                        It.IsAny<CancellationToken>()))
+                       .ReturnsAsync(true);
 
-            // Mock async update behavior
-            _mockClient.Setup(client => client.UpdateAsync(key, "modPayload")).ReturnsAsync(true);
             var update = await _sharpConnectorClient.UpdateAsync(key, "modPayload");
             Assert.IsTrue(update);
         }
@@ -122,9 +134,8 @@ public void Delete()
             var insert = _sharpConnectorClient.Insert(key, "payload");
             Assert.IsTrue(insert);
             var obj = _sharpConnectorClient.Get(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
 
-            // Mock delete behavior
             _mockClient.Setup(client => client.Delete(key)).Returns(true);
             var delete = _sharpConnectorClient.Delete(key);
             Assert.IsTrue(delete);
@@ -137,12 +148,15 @@ public async Task DeleteAsync()
             var insert = await _sharpConnectorClient.InsertAsync(key, "payload");
             Assert.IsTrue(insert);
             var obj = await _sharpConnectorClient.GetAsync(key);
-            Assert.AreEqual(obj, "payload");
+            Assert.AreEqual("payload", obj);
+
+            _mockClient.Setup(client => client.DeleteAsync(
+                                        key,
+                                        It.IsAny<CancellationToken>()))
+                       .ReturnsAsync(true);
 
-            // Mock async delete behavior
-            _mockClient.Setup(client => client.DeleteAsync(key)).ReturnsAsync(true);
             var delete = await _sharpConnectorClient.DeleteAsync(key);
             Assert.IsTrue(delete);
         }
     }
-}
+}

src/SharpConnector.Tests/SharpConnector.Tests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
 
     <IsPackable>false</IsPackable>
 
@@ -25,10 +25,10 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
     <PackageReference Include="Moq" Version="4.20.72" />
-    <PackageReference Include="MSTest.TestAdapter" Version="3.8.3" />
-    <PackageReference Include="MSTest.TestFramework" Version="3.8.3" />
+    <PackageReference Include="MSTest.TestAdapter" Version="3.10.2" />
+    <PackageReference Include="MSTest.TestFramework" Version="3.10.2" />
     <PackageReference Include="coverlet.collector" Version="6.0.4">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

src/SharpConnector/Connectors/ArangoDb/ArangoDbAccess.cs

@@ -46,7 +46,9 @@ public async Task<bool> IsConnectedAsync()
         {
             try
             {
-                var databases = await Client.Database.GetDatabasesAsync().ConfigureAwait(false);
+                var databases = await Client.Database
+                    .GetDatabasesAsync()
+                    .ConfigureAwait(false);
                 return !databases.Error;
             }
             catch (Exception)