Add the ruby gem "certified" for additional CA sources#10
Open
basvodde wants to merge 8 commits intoendymion:masterfrom
Open
Add the ruby gem "certified" for additional CA sources#10basvodde wants to merge 8 commits intoendymion:masterfrom
basvodde wants to merge 8 commits intoendymion:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connecting to HTTPS, the certs sometimes fail. One easy solution is to have the 'certified' gem as a dependency. This is easier than most other solutions and I guess it will occur pretty often when people use link-checker. Other solutions would require action from the actual user on this.
One example where it failed for me was github.
I tried writing a spec for the additional require (which is the only LOC change) but as all the specs are proper unit tests and there are no integration tests at the moment, I figured it'll be hard to emulate in a unit test. So, for now, no added tests. (some integration specs might be a nice addition)