Add 95% CI error bars to CE and CW examples (Sourcery refactored)#19
Add 95% CI error bars to CE and CW examples (Sourcery refactored)#19sourcery-ai[bot] wants to merge 1 commit into
Conversation
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.08%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
550d856 to
a3e0575
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## error_bars #19 +/- ##
===========================================
Coverage 97.40% 97.40%
===========================================
Files 18 18
Lines 463 463
===========================================
Hits 451 451
Misses 12 12 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
a3e0575 to
9c93897
Compare
| running as many simulations, however the Coombs results are consistently | ||
| high. | ||
| """ | ||
|
|
There was a problem hiding this comment.
Lines 96-96 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| | SU max | 100.0 | 84.1 | 79.6 | 78.4 | 77.3 | 77.5 | | ||
| | CW | 100.0 | 91.7 | 83.1 | 75.6 | 64.3 | 52.9 | | ||
| """ | ||
|
|
There was a problem hiding this comment.
Lines 54-133 refactored with the following changes:
- Merge consecutive list appends into a single extend (
merge-list-appends-into-extend) - Replace unused for index with underscore (
for-index-underscore)
This removes the following comments ( why? ):
# Likelihood of Condorcet Winner (normalized by n elections)
| # Reuse the same chunk of memory to save time | ||
| election = np.empty((n_voters, n_cands), dtype=np.uint8) | ||
| for iteration in range(batch_size): | ||
| for _ in range(batch_size): |
There was a problem hiding this comment.
Function simulate_batch refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
Pull Request #14 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
error_barsbranch, then run:Help us improve this pull request!