EknVfs: g_file_parse_name("~") does not work - #12
Open
dylanmccall wants to merge 2 commits into
Open
Conversation
Previously, ekn_vfs_get_file_for_uri was testing whether elements in a tokens array were null, without testing the size of the array. This change adds one additional call to g_strsplit. The first is to separate the URI scheme from the path, and the second is to separate tokens in the path. Tokens are then assigned to variables for readability. https://phabricator.endlessm.com/T23125
dylanmccall
force-pushed
the
dylanmccall/T23125
branch
from
September 11, 2019 20:21
3f01e9d to
c4c7300
Compare
dnohales
reviewed
Sep 11, 2019
dylanmccall
force-pushed
the
dylanmccall/T23125
branch
2 times, most recently
from
September 12, 2019 00:02
19567a6 to
8eb1b3c
Compare
dylanmccall
marked this pull request as ready for review
September 12, 2019 00:06
Contributor
|
@xjuan might be a good reviewer for this code! |
dnohales
suggested changes
Sep 12, 2019
dylanmccall
force-pushed
the
dylanmccall/T23125
branch
from
September 13, 2019 01:22
8eb1b3c to
99eb061
Compare
With this change, ekn_vfs_parse_name uses the same behaviour as ekn_vfs_get_file_for_uri to decide whether a URI scheme is supported. If it is not, the implementation of parse_name from GLocalVfs is used instead. This behaviour is consistent with the existing behaviour, since ekn_vfs_get_file_for_uri also falls back to the implementation of get_file_for_uri from GLocalVfs when the scheme is not supported. This is necessary because parse_name and get_file_for_uri behave differently in GLocalVfs for certain paths. https://phabricator.endlessm.com/T23125
dylanmccall
force-pushed
the
dylanmccall/T23125
branch
from
September 13, 2019 01:40
99eb061 to
ce231b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T23125