PPC pooled data references: Add support for subi, addis, and subis instructions#245
Merged
LagoLunatic merged 1 commit intoencounter:mainfrom Aug 23, 2025
Merged
PPC pooled data references: Add support for subi, addis, and subis instructions#245LagoLunatic merged 1 commit intoencounter:mainfrom
subi, addis, and subis instructions#245LagoLunatic merged 1 commit intoencounter:mainfrom
Conversation
…is` instructions
encounter
approved these changes
Aug 23, 2025
Collaborator
Author
That's a good point. I also just checked the flow_analysis code and it looks like there's a similar pattern there that I think could theoretically cause a bug for stringBase, but I can't find any code that uses subi on a stringBase so it may not be an issue in practice. Might be worth refactoring both of them to not use simplified form anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the pooled reference calculation would mistake the
subiinstruction foraddibecause they have the same opcode and are only distinguished by their mnemonic string.Before:


After:
Also adds support for the

addisandsubisinstructions, which can sometimes be used by the compiler for very large data pools: