Implement diffing individual data symbols#244
Merged
encounter merged 16 commits intoencounter:mainfrom Sep 3, 2025
Merged
Conversation
Collaborator
Author
|
I reworked the whole-section-symbol diffing a bit. Now, it doesn't try to reuse the real section symbols from the object at all like it did before, since those might not necessarily exist, or might only exist for some sections. Instead it creates a fake section symbol for each section with a unique name, and it does this at the end after sections have been combined. This fixes the following issues with the previous implementation:
|
# Conflicts: # objdiff-cli/src/cmd/report.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implements diffing the data of just a single symbol when you click on it. This is useful for things like vtables and stringBases:
Fixes #173