Implementation of basic data flow analysis for PowerPC#212
Merged
encounter merged 17 commits intoencounter:mainfrom Jun 17, 2025
Merged
Implementation of basic data flow analysis for PowerPC#212encounter merged 17 commits intoencounter:mainfrom
encounter merged 17 commits intoencounter:mainfrom
Conversation
* Show string constants inline * Handle calls to MWCC "sled" helpers which otherwise disrupt flow analysis
…where there is a branch to the subsequent instruction with a different register value.
…than all data flow values.
Owner
|
This is awesome work, thanks so much! Very interested in seeing this continue to improve and replace the pooled data impl eventually. I made a few minor tweaks ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement basic data flow analysis, showing known values in place of registers where we have more information about the contents of the register available.
Features
Settings
The PR includes two additional settings,
analyzeDataFlowandshowDataFlowanalyzeDataFlowdefaults to false and gates the whole feature: No analysis is done unless this setting is enabled. It is currently exposed as "(Experimental) Perform data flow analysis" under Arch Settings -> PowerPC. It's not prepended with "ppc." because I think this should be a general setting that could apply to all arches, I just put it under PowerPC because it only applies to that so far.showDataFlowdefaults to true and shows the data flow results in place of register names ifanalyzeDataFlowwas enabled and there are data flow results for the argument in question. This is exposed as checkbox at the top of the diff view in the case whenanalyzeDataFlowis enabled.