Reimplement colorized data relocation hover diffs#182
Merged
encounter merged 3 commits intoencounter:mainfrom Mar 29, 2025
Merged
Reimplement colorized data relocation hover diffs#182encounter merged 3 commits intoencounter:mainfrom
encounter merged 3 commits intoencounter:mainfrom
Conversation
Data diffing doesn't seem to be fully implemented in objdiff-wasm yet, so just putting placeholders in so it compiles.
Owner
|
Maybe we can add separators before “Relocation”? That might help it visually flow better. I also think we can ignore custom colors (like Virtual address) in this case, acting more like a “override”, if that makes sense. |
Collaborator
Author
Owner
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#154 161dadd Change font color for nonmatching relocs on hover