Skip to content

added timeouts to socks5 connection initialization #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Brranton
Copy link

@Brranton Brranton commented Jun 6, 2025

Summary

added timeouts to socks5 connection initialization

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Brranton added 5 commits June 6, 2025 17:45
set timeouts for socks5 connection initialization
changed annotation type
Fixed a typo in “typle”
added timeouts for socks5 connection initialization in _async\socks_proxy.py
function _init_socks5_connection is reformatted
@Brranton
Copy link
Author

Brranton commented Jun 6, 2025

this fixes issue #1015

@dmittov
Copy link

dmittov commented Aug 6, 2025

Thanks! I faced this issue today.
Socks proxy doesn't respond and the code stuck on awaiting stream.read much longer than I expected passing the explicit timeout to the request.

I hope this fix is merges soon. Looking forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants