Add msgCounter to OHPCF result callbacks#231
Merged
Merged
Conversation
Follow-up to enbility#210, which added msgCounter to WriteLoadControlLimits/ WriteConsumptionLimit/WriteProductionLimit but missed OHPCF's Schedule/Abort/Pause/ResumePowerConsumptionProcess, leaving the result callback signature inconsistent across usecases.
Contributor
Author
|
@sthelen-enqs also had to gofmt the file which #223 omitted. |
andig
added a commit
to evcc-io/evcc
that referenced
this pull request
Jul 7, 2026
enbility/eebus-go#231 adds msgCounter to OHPCF's process-control result callbacks upstream, closing the inconsistency PR #210 left behind. Pull in that fix (on top of the still-unmerged MDT patch) and drop the adapter closures that bridged the old single-arg callback.
andig
changed the title
sthelen-enqs
approved these changes
Jul 8, 2026
sthelen-enqs
left a comment
sthelen-enqs
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this, the two branches for this and OHPCF were run separated for too long so we forgot to update this for OHPCF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #210 as requested in #210 (comment).
#210 added
msgCounterto the result callback forWriteLoadControlLimits(OPEV/OSCEV) andWriteConsumptionLimit/WriteProductionLimit(EG LPC/LPP), but didn't touch OHPCF'sSchedulePowerConsumptionProcess/AbortPowerConsumptionProcess/PausePowerConsumptionProcess/ResumePowerConsumptionProcess, leaving the result-callback shape inconsistent across usecases (OHPCF still only getsfunc(result model.ResultDataType)).This applies the same change to OHPCF's four write methods and their shared
writeSmartEnergyManagementDatahelper, mirroring #210's pattern exactly.