This repository was archived by the owner on Jun 30, 2020. It is now read-only.
Use recv/send for non-stdio in the test tooling #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should increase the test coverage to also cover send/recv. AlternativeTo: enarx-archive#28 Signed-off-by: Patrick Uiterwijk <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 64.87% 65.84% +0.97%
==========================================
Files 13 13
Lines 1170 1174 +4
==========================================
+ Hits 759 773 +14
+ Misses 411 401 -10
Continue to review full report at Codecov.
|
|
I'm glad this seems to work! However, I think we can't filter by the file descriptor number. We should be able to use (I think) @yingxiongraomingzk Take a look at this. |
|
This is a great idea! I will follow up with |
DK-DARKmatter
pushed a commit
to DK-DARKmatter/tlssock
that referenced
this pull request
Mar 26, 2019
recv/send function can only be applied to a socket. We can use fstat() function to check if the fd is a socket or not. If so, we would like to use recv/send function to replace read/write. Related to:enarx-archive#30 Signed-off-by: Ke Zhao <[email protected]>
DK-DARKmatter
pushed a commit
to DK-DARKmatter/tlssock
that referenced
this pull request
Mar 27, 2019
recv/send function can only be applied to a socket. We can use fstat() function to check if the fd is a socket or not. If so, we would like to use recv/send function to replace read/write. Related to:enarx-archive#30 Signed-off-by: Ke Zhao <[email protected]>
|
Replaced by #31 . |
DK-DARKmatter
pushed a commit
to DK-DARKmatter/tlssock
that referenced
this pull request
Apr 4, 2019
recv/send function can only be applied to a socket. We can use fstat() function to check if the fd is a socket or not. If so, we would like to use recv/send function to replace read/write. Related to:enarx-archive#30 Signed-off-by: Ke Zhao <[email protected]>
DK-DARKmatter
pushed a commit
to DK-DARKmatter/tlssock
that referenced
this pull request
Apr 5, 2019
recv/send function can only be applied to a socket. We can use fstat() function to check if the fd is a socket or not. If so, we would like to use recv/send function to replace read/write. Related to:enarx-archive#30 Signed-off-by: Ke Zhao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should increase the test coverage to also cover send/recv.
AlternativeTo: #28
Signed-off-by: Patrick Uiterwijk [email protected]