Cleanup some test. NFC #24861
Cleanup some test. NFC #24861
Conversation
|
@tlively for test_wasm_intrinsics_simd changes |
test/test_core.py
Outdated
| '': ([],), | ||
| 'unsigned_char': (['-funsigned-char'],), | ||
| }) | ||
| def test_wasm_intrinsics_simd(self, args): | ||
| # Improves test readability |
There was a problem hiding this comment.
This comment goes with the -Wno-c++11-narrowing, but it looks like that flag was mistakenly dropped.
There was a problem hiding this comment.
But this test is not doesn't contain any such warnings.. and its not even a C++ test.
I.e. if I can remove the -Wno-xxx flag and no warnings show up then its not doing anything right?
There was a problem hiding this comment.
Oh interesting, I guess so. We should just remove the comment, too, then.
| # remove -g, so we have one test without it by default | ||
| self.cflags = [x for x in self.cflags if x != '-g'] |
There was a problem hiding this comment.
Are we worried about losing this coverage?
There was a problem hiding this comment.
We have versions of the core test suite that include -g and tests that don't.
Notably I don't think any of the ones that we run by default include -g .. so this just seems pointless.
oops, i thought I had done that already. |
- Avoid assignment (prefer mutation) to self.cflags (see emscripten-core#24860 for why this is better). - Parameterize test_wasm_intrinsics_simd and remove unneeded arguments. - Use inline cflags where it improves test readability. - Remove use of EMSCRIPTEN_KEEPALIVE with `main` function.
mainfunction.