Skip to content

Prefer mutex typedefs provided by musl #24842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kleisauke
Copy link
Collaborator

Followup to #24773.

This is an automatic change generated by tools/maint/rebaseline_tests.py.

The following (2) test expectation files were updated by
running the tests with `--rebaseline`:

```
code_size/test_codesize_minimal_pthreads.json: 27171 => 27169 [-2 bytes / -0.01%]
code_size/test_codesize_minimal_pthreads_memgrowth.json: 27603 => 27601 [-2 bytes / -0.01%]

Average change: -0.01% (-0.01% - -0.01%)
```
@kleisauke
Copy link
Collaborator Author

This appears to save 2 bytes in the other.test_codesize_minimal_pthreads and other.test_codesize_minimal_pthreads_memgrowth codesize tests.

I'm not sure why these 2 typedefs were not using volatile void *volatile __p[6] in the first place (as done in https://git.musl-libc.org/cgit/musl/commit?id=de7e99c58508ca70f0b1b8ef259a823a3766c434), but I suspect they were manually updated in commit 31cf2bb.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the tests pass.

@sbc100
Copy link
Collaborator

sbc100 commented Aug 1, 2025

Sorry about the expectations failures.. there seems to be particularly volatile right now .

@kleisauke
Copy link
Collaborator Author

No worries, GitHub has now a "Update branch" button. I'll press that once PR #24844 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants