Skip to content

Cleanup code for capturing document.currentScript in MODULARIZE mode. #24535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 9, 2025

This refactor makes it clear exactly if/when we need the extra closure. It also elides the closure completely when one is not needed.

@sbc100 sbc100 requested a review from brendandahl June 9, 2025 23:08
This refactor makes it clear exactly if/when we need the extra
closure.  It also elides the closure completely when one is not needed.
@sbc100 sbc100 requested review from kleisauke and dschuff June 9, 2025 23:35
Copy link
Collaborator

@kleisauke kleisauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbc100 sbc100 merged commit 51539ef into emscripten-core:main Jun 10, 2025
30 checks passed
@sbc100 sbc100 deleted the _scriptName branch June 10, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants