Fix MINGW32 errors and warnings #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This also fixes #219. |
* Include `share.h` for `_SH_DENYNO`’s definition * Define `NOMINMAX` only if not already defined; MINGW warns of redefinition since `bits/os_defines.h` included by `<algorithm>` already defines it * Use C++11 `thread_local` instead of the non-standard option of `__declspec(thread)` [1] [1]: https://learn.microsoft.com/en-us/cpp/cpp/thread?view=msvc-170
legends2k
force-pushed
the
fix_fsopen_error
branch
from
6ddec3b to
160ad58
Compare
neheb
approved these changes
Nov 26, 2022
Closed
Author
|
Used @emilk Please let me know if you've concerns around this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share.hfor_SH_DENYNO’s definitionNOMINMAXonly if not already defined; MINGW warns of redefinition sincebits/os_defines.hincluded by<algorithm>already defines itthread_localinstead of the non-standard option of__declspec(thread)1