-
Notifications
You must be signed in to change notification settings - Fork 57
Make parameter and objective classes slotted #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: there was another issue which messed with our subclass detection mechanism, which has already be resolved but the fix has not yet been released. However, the checks should automatically pass once attrs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there is not really a need for a proper and full review, this is just some maintenance right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
8d645aa
to
4b98c3f
Compare
@AVHopp @Scienfitz, FYI: I rebased and added one more commit since in the meantime we also had to make our |
4b98c3f
to
3a33fda
Compare
3a33fda
to
a3e527c
Compare
a3e527c
to
6437b75
Compare
6437b75
to
0d2e7e8
Compare
Again on hold until the following blocking issue gets resolved: |
Not happening much on the |
@AdrianSosic - "a few more weeks" is over by half a year, any updates here? |
Nothing I can do at the moment. I know that there is something happing due to changes in Python 3.14, but unclear if it will resolve the issue. And workarounds/fixes from our end would require waiting for the new docs. I'll close the issue now and will reconsider once there is a reason to do so |
Now that
attrs==24.1.0
supportscached_property
with slotted classes, we can finally enable slots for our parameter and objective classes.