Support @babel/eslint-parser v8#221
Open
aklkv wants to merge 3 commits into
Open
Conversation
v8 removed the /experimental-worker subpath, which left babelParser null and produced a misleading 'requires @babel/eslint-parser' error on .gjs/.gts files. Fall back to the package main entry (same synchronous parseForESLint) and widen the peer range to ^7.28.6 || ^8.0.0.
NullVoxPopuli
requested changes
Jun 20, 2026
aklkv
commented
Jun 21, 2026
| "repository": { | ||
| "type": "git", | ||
| "url": "git@github.com:ember-tooling/ember-eslint-parser.git" | ||
| "url": "git+https://github.com/ember-tooling/ember-eslint-parser.git" |
Contributor
Author
There was a problem hiding this comment.
lint:package was complaning about it
Member
There was a problem hiding this comment.
Can you put this in a separate pr please?
Member
There was a problem hiding this comment.
We don't really want to test that resolution works - that's easy
We want to test that someone can actually use babel 8
Member
There was a problem hiding this comment.
And this test only tests what's in the test file
aklkv
force-pushed
the
support-babel-8-eslint-parser
branch
from
9e82091 to
f3b8146
Compare
aklkv
force-pushed
the
support-babel-8-eslint-parser
branch
from
f3b8146 to
2fae91f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8 removed the /experimental-worker subpath, which left babelParser null and produced a misleading 'requires @babel/eslint-parser' error on .gjs/.gts files. Fall back to the package main entry (same synchronous parseForESLint) and widen the peer range to ^7.28.6 || ^8.0.0.