Skip to content

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Jun 20, 2025

Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit 6d4ba57
🔍 Latest deploy log https://app.netlify.com/projects/ember-deprecations/deploys/68598181b0aeee0007bac55c
😎 Deploy Preview https://deploy-preview-1409--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

There is no direct replacement for `reopen`. You should refactor your code to avoid this pattern. If you need to add functionality, consider creating a subclass:

```javascript
import MyComponent from './my-component';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance we can use a word other than component?

I don't want folks to get the idea that we condone component extension at all (even for native classes)

@ef4
Copy link
Contributor

ef4 commented Jun 27, 2025

Should this also deprecate the @classic decorator? It was intended as a development-time guiderail when moving between the class syntaxes, and shouldn't be a thing once classic syntax is gone.

@wagenet
Copy link
Contributor Author

wagenet commented Jul 15, 2025

@ef4 we should deprecate it, but I'm not sure we need to call it out in these guides.

since: 6.5.0
---

With the introduction of native class syntax in JavaScript, Ember is deprecating its classic class syntax, which includes `extend`, `reopen`, and `reopenClass`. This guide will help you migrate your code to the modern syntax.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably mention the codemod for native classes, as well as a migration path: emberjs/rfcs#1117 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants