Add handling for multi-word C compilation commands like zig cc#183
Open
widlarizer wants to merge 1 commit intoembench:masterfrom
Open
Add handling for multi-word C compilation commands like zig cc#183widlarizer wants to merge 1 commit intoembench:masterfrom
widlarizer wants to merge 1 commit intoembench:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is no-op for single word CC values like "gcc" or "clang" and enables the use of multi-word compiler invocations like "zig cc" or "mysecretcompiler --license-var=example.com" that can't be split into CC and CFLAGS or logically don't make sense to do so. For comparison, CMake handles it by splitting along
;:-DCMAKE_C_COMPILER="zig;cc;--target=riscv32-freestanding". This PR isn't consistent with that but is consistent with shell invocations. It can easily be changed into the semicolon version.